Basic support for axis simplification and arbitrary order in iterators#979
Open
Basic support for axis simplification and arbitrary order in iterators#979
Conversation
jturner314
reviewed
Apr 11, 2021
e5224a5 to
49bf28a
Compare
08068a8 to
2d6bcde
Compare
These `pub` here actually predate the pub(crate) feature, and they should just be `pub(crate)` or lower since they are unreachable outside the crate.
This is special for arrays of shape 1 x n or n x 1; add iterator and iterator sum (fold) benchmarks.
Implement axis merging - this preserves order of elements in the iteration but might simplify iteration. For example, in a contiguous matrix, a shape like [3, 4] can be merged into [1, 12]. Also allow arbitrary order optimization - we then try to iterate in memory order by sorting all axes, currently.
This one complains about if let Some(_) = option; which I still think is just as fine as if option.is_some(); `if let` is a nice Rust feature that works the same way on all enums, no reason to prefer option-specific methods like `is_some`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current state of the PR: groundwork, not actually used in any iterator